Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpga makefile clean fix #1357

Merged
merged 1 commit into from
Feb 23, 2023
Merged

fpga makefile clean fix #1357

merged 1 commit into from
Feb 23, 2023

Conversation

joonho3020
Copy link
Contributor

Related PRs / Issues:

#1354 had a temporary fix for #1355 by adding miscellaneous things to SIM_FILE_REQS.
This is a cleaner fix.

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this applicable to the vlsi Makefile too?

@abejgonzalez
Copy link
Contributor

Is this applicable to the vlsi Makefile too?

I believe so. @joey0320 bump that as well in this PR?

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joonho3020 joonho3020 merged commit 3461cd3 into main Feb 23, 2023
@jerryz123 jerryz123 deleted the fpga-makefile-fix branch February 28, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants