Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DRAMSim2 to avoid verbose log files #1468

Merged
merged 1 commit into from
May 10, 2023
Merged

Bump DRAMSim2 to avoid verbose log files #1468

merged 1 commit into from
May 10, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented May 10, 2023

Recent fixes to DRAMSim2 model meant verbose dramsim.log files were being generated wherever sims are run.
This avoids that by disabling the logging in DRAMSim2

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DRAMSim2 Makefile added PIC... how does that disable logging?

@jerryz123
Copy link
Contributor Author

No I pushed a commit to master that disabled logging. The fPIC is irrelevant.

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wasn't thinking and I clicked the PR instead of looking at the direct diff given.

@jerryz123 jerryz123 merged commit 2025073 into main May 10, 2023
@jerryz123 jerryz123 deleted the dramsim2bump branch May 10, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants