Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to latest rocket-chip #1475

Merged
merged 10 commits into from
May 31, 2023
Merged

Bump to latest rocket-chip #1475

merged 10 commits into from
May 31, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented May 12, 2023 •
edited
Loading

This bump should make it possible to integrate #1469 into firesim without other RTL changes

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 force-pushed the bumprc branch 6 times, most recently from 66e1889 to 80a4534 Compare May 13, 2023 20:37
@jerryz123 jerryz123 force-pushed the bumprc branch 3 times, most recently from 03fa0db to a91d6d4 Compare May 14, 2023 23:37
@jerryz123 jerryz123 force-pushed the bumprc branch 4 times, most recently from d794581 to 614277d Compare May 19, 2023 18:30
abejgonzalez
abejgonzalez reviewed May 20, 2023
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets hold off on this until mid-next week.

@jerryz123 jerryz123 merged commit ea127aa into main May 31, 2023
@jerryz123 jerryz123 deleted the bumprc branch May 31, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

@sagark sagark Awaiting requested review from sagark

Assignees
No one assigned
Labels
changelog:omit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryz123 @abejgonzalez