Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Makefile Fixes #1496

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Misc Makefile Fixes #1496

merged 2 commits into from
Jun 2, 2023

Conversation

abejgonzalez
Copy link
Contributor

Fixes issue where if the compilation was stopped (i.e CTRL-C'ed during the firtool recipe) it would fail to update any transient make variable (since the old $(SFC_LEVEL) $(EXTRA_FIRRTL_OPTIONS) $(FINAL_ANNO_FILE) $(MFC_LOWERING_OPTIONS) recipe would not be re-run). Instead of transiently updating variables, instead store the results to a file so that make can properly track what variables updated.

Always try to dump with sources inlined for any of the run-* targets.

Sometimes when SBT assembly is run and the *.jar it is supposed to change/generate is cached/up-to-date it will not touch the output *.jar file. Therefore force touch it so that it is updated for future make requirements.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

variables.mk Outdated Show resolved Hide resolved
@abejgonzalez abejgonzalez merged commit 3e0415e into main Jun 2, 2023
@jerryz123 jerryz123 deleted the misc-fixes-2 branch August 22, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants