Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump constellation to fix interconnect FIFO-fixers #1510

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Jun 13, 2023

Constellation NoCs by-default do not preserve FIFO-ness. This bump makes the NoCs correctly report the lack of FIFO-ness, so the NoC buswrapper will correctly insert FIFOFixers to domains that should be FIFO

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Constellation NoCs by-default do not preserve FIFO-ness.
This bump makes the NoCs correctly report the lack of FIFO-ness, so the
NoC buswrapper will correctly insert FIFOFixers to domains that
should be FIFO
@jerryz123 jerryz123 merged commit 9f7bda4 into main Jun 14, 2023
@jerryz123 jerryz123 deleted the fifo-noc branch June 14, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants