Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve peripheral fragments to include more peripheral devices and support instantiating multiple instances of same device #1511

Merged
merged 5 commits into from
Jun 14, 2023

Conversation

T-K-233
Copy link
Member

@T-K-233 T-K-233 commented Jun 14, 2023

Improve peripheral fragments to include more peripheral devices and support instantiating multiple instances of same device

This is a new PR regarding the discussion in #1397:

  • Removed WithUARTOverride per requested. User can generate ChipConfig from scratch if the default UART address need to be changed.
  • Added several other helpful peripheral config fragments, which are used in the tapeout class chip.
  • Minor addition on ignoring the .vscode/ folder.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated thexconda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

})

class WithNoDebug extends Config((site, here, up) => {
case DebugModuleKey => None
})

class WithDMIDTM extends Config((site, here, up) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this one already provided by rocket-chip?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I'm not using this one. I can remove it.

@jerryz123 jerryz123 merged commit 4d8b3f9 into main Jun 14, 2023
@jerryz123 jerryz123 deleted the improve-peripheral branch June 14, 2023 17:12
jerryz123 added a commit that referenced this pull request Jun 15, 2023
This reverts commit 4d8b3f9, reversing
changes made to d287fed.
jerryz123 added a commit that referenced this pull request Jun 19, 2023
jerryz123 added a commit that referenced this pull request Jul 10, 2023
Improve peripheral config binders (Reapply #1511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants