Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KLayout section of Sky130+OpenROAD tutorial #1514

Merged
merged 16 commits into from
Sep 5, 2023
Merged

KLayout section of Sky130+OpenROAD tutorial #1514

merged 16 commits into from
Sep 5, 2023

Conversation

nayiri-k
Copy link
Contributor

@nayiri-k nayiri-k commented Jun 14, 2023

Hammer now supports running DRC with KLayout, which is the preferred method for running DRC on Sky130 designs according to Efabless.

This PR also includes specific tool versions + better install directions with conda for the Sky130+OpenROAD tutorial, as most of the issues experienced by chipyard uses stemmed from these.

Also bumps the Hammer version in chipyard.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@nayiri-k nayiri-k marked this pull request as ready for review June 14, 2023 17:21
Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you also include the small fix for #1508 (remove single-quotes around true) before merging?

@nayiri-k nayiri-k mentioned this pull request Jun 30, 2023
16 tasks
@jerryz123
Copy link
Contributor

Shouldn't one of the YAMLs in conda-reqs (not the conda-lock yamls) be updated? How do we regenerate the conda-lock files?

KLayout needs gcc 13.1?

@jerryz123
Copy link
Contributor

@nayiri-k @harrisonliew Is this good to merge now? It looks fine to me, although whatever changed with the run-tutorial CI is timing out. Perhaps we can remove that, if something was added (although we can do that in another PR so we can get this in).

@jerryz123 jerryz123 merged commit e148a32 into main Sep 5, 2023
53 checks passed
@jerryz123 jerryz123 deleted the klayout-docs branch September 5, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants