Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Caliptra AES256 ECB engine as RoCC accelerator #1642

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Nov 2, 2023

Adds https://github.com/chipsalliance/Caliptra 's AES 256 ECB cryptography core as a RoCC accelerator. Also adds a repo to help users create RoCC memory streaming accelerators (i.e. extend the classes/traits to quickly create a streaming accel).

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

build.sbt Outdated Show resolved Hide resolved
.github/scripts/defaults.sh Outdated Show resolved Hide resolved
@jerryz123
Copy link
Contributor

The submodule should also get added to .github/scripts/check-commit.sh

@abejgonzalez
Copy link
Contributor Author

Requires #1639 before this PR is merged.

@abejgonzalez
Copy link
Contributor Author

@Mergifyio rebase

Copy link

mergify bot commented Nov 6, 2023

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/4)
Rebasing (2/4)
Rebasing (3/4)
Rebasing (4/4)
Auto-merging .github/scripts/check-commit.sh
CONFLICT (content): Merge conflict in .github/scripts/check-commit.sh
error: could not apply 7525b9fd... Fix CI | Fix Verilator compile
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 7525b9fd... Fix CI | Fix Verilator compile

@abejgonzalez abejgonzalez merged commit fff36c4 into main Nov 6, 2023
8 checks passed
@jerryz123 jerryz123 deleted the caliptra-aes branch January 21, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants