Add HasHarnessInstantiators into MultiHarnessBinder #1674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, users should be able to generate arb. RTL in the harness and connect up any clock they want to it (for example to connect up a queue between IOs, debugging loggers, etc). This is supported with current
HarnessBinders
but not withMultiHarnessBinders
specifically because theMulti*
version doesn't have access toth: HasHarnessInstantiators
. This adds this back to theMultiHarnessBinder
when it was dropped on the PortAPI changes.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?