Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spike devices #1692

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Add spike devices #1692

merged 2 commits into from
Dec 16, 2023

Conversation

joonho3020
Copy link
Contributor

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you build and install this library at the end of build-toolchain-extra.sh? spike-devices should install to the $RISCV directory

docs/Software/Spike.rst Show resolved Hide resolved
docs/Software/Spike.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@kevindna kevindna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you do this? for clarity?

@jerryz123
Copy link
Contributor

I know it's not really a high priority item, but we should at least make some minimal effort to maintain the commit log. 😁

commit --amend exists for a reason.

@joonho3020
Copy link
Contributor Author

I know it's not really a high priority item, but we should at least make some minimal effort to maintain the commit log. 😁

commit --amend exists for a reason.

Yeah... I concede... my commit messages are bad

@jerryz123
Copy link
Contributor

I don't think this rebase did the right thing

@jerryz123 jerryz123 merged commit 928ff92 into main Dec 16, 2023
51 checks passed
@jerryz123 jerryz123 deleted the better-spike branch December 16, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants