Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearer --skip flags to build-setup #1724

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Add clearer --skip flags to build-setup #1724

merged 1 commit into from
Jan 5, 2024

Conversation

jerryz123
Copy link
Contributor

Easier to remember flags than numbers.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 merged commit cecb6e7 into main Jan 5, 2024
51 of 52 checks passed
@jerryz123 jerryz123 deleted the bs-improvements branch January 5, 2024 18:54
@T-K-233
Copy link
Member

T-K-233 commented Jan 5, 2024

Is it better to name it "steps (6 & 7)" instead of "steps (6/7)"

@jerryz123
Copy link
Contributor Author

Is it better to name it "steps (6 & 7)" instead of "steps (6/7)"

Good point, can you open a PR fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants