-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastSimRocketConfig with no TLMonitors #1752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the text in the PR to reflect the new change, then I'll approve
|
||
class FastRTLSimRocketConfig extends Config( | ||
new freechips.rocketchip.subsystem.WithoutTLMonitors ++ | ||
new chipyard.RocketConfig) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that there is nowhere in the docs that has a concrete example of overriding the default CONFIG. Maybe this isn't necessary... but perhaps one line can be added:
To simulate this config, you can run:
`make run-binary CONFIG=FastRTLSimRocketConfig BINARY=... LOADMEM=1`
Due to the active chiplet development, the complexity of
TLMonitors
has exploded 😢 .This causes RTL simulation speed to go down by 2x which is a significant regression.
We want to add a example configuration where we remove the
TLMonitors
and add some documentation of this phenomenon.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?