Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve insert includes #1902

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Improve insert includes #1902

merged 4 commits into from
Jun 14, 2024

Conversation

bwhitchurch
Copy link
Contributor

Encapsulate some functionalities of the insert_includes.py into sub functions to be more readable.
Process includes in a single pass through the temp file with DFS
Format according to pep8 style

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Brandon Whitchurch added 4 commits June 13, 2024 08:19
fixes for insert includes
316c41e 
    - avoid infinite loop condition
    - follow pep8 style guide
    - encapsulate some functionality to decrease visual nesting
add check for duplicate include directives
feeab6b
use DFS to recursively search and expand includes in a single pass
e4e49ef
remove debug print
ecd7c80
jerryz123
jerryz123 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is much nicer

@jerryz123 jerryz123 merged commit 7f5b6a9 into ucb-bar:main Jun 14, 2024
1 check passed
@bwhitchurch bwhitchurch deleted the fix-insert-includes branch June 14, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryz123 jerryz123 jerryz123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwhitchurch @jerryz123