Check and add Hwacha tests #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@a0u previously used a cleaner way to query the Hwacha parameters. I am using that instead. |
abejgonzalez
commented
Oct 13, 2019
a0u
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
This works fine for now, although there should be a more scalable approach of injecting tests as part of the accelerator mix-in.
This scheme also doesn't support heterogenous RoCC configurations, but that is a broader issue with the assembly tests themselves.
|
I agree this mechanism is just to make things work. We need to think more about how to inject tests based on tiles, rocc modules, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic example of checking for a Hwacha parameter to add its tests.