Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VLSI Makefile #318

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Fix VLSI Makefile #318

merged 2 commits into from
Oct 25, 2019

Conversation

abejgonzalez
Copy link
Contributor

The SMEMS_FILE was supposed to be TOP_SMEMS_FILE

@abejgonzalez
Fix VLSI Makefile [skip ci]
540fff5 
The `SMEMS_FILE` was supposed to be `TOP_SMEMS_FILE`
@abejgonzalez abejgonzalez self-assigned this Oct 25, 2019
abejgonzalez
abejgonzalez commented Oct 25, 2019
View reviewed changes
vlsi/Makefile Outdated Show resolved Hide resolved
colinschmidt
colinschmidt approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the catch

harrisonliew
harrisonliew approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's curious how I never ran into this bug, but LGTM too.

@abejgonzalez abejgonzalez merged commit b73e43a into dev Oct 25, 2019
@jerryz123 jerryz123 mentioned this pull request Jan 22, 2020
Merged
@abejgonzalez abejgonzalez deleted the abejgonzalez-patch-1 branch January 23, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinschmidt colinschmidt colinschmidt approved these changes

@harrisonliew harrisonliew harrisonliew approved these changes

@dpgrubb13 dpgrubb13 Awaiting requested review from dpgrubb13

Assignees

@abejgonzalez abejgonzalez

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abejgonzalez @colinschmidt @harrisonliew