Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partition vlsi/build on design #331

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Partition vlsi/build on design #331

merged 2 commits into from
Nov 7, 2019

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Nov 6, 2019 •
edited
Loading

Splits vlsi/build on the type of design.

Covers #220. Fixes #187

@abejgonzalez abejgonzalez self-assigned this Nov 6, 2019
harrisonliew
harrisonliew requested changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comment, I support this partitioning.

vlsi/Makefile Outdated Show resolved Hide resolved
@abejgonzalez abejgonzalez merged commit 9f720e0 into dev Nov 7, 2019
@abejgonzalez abejgonzalez deleted the vlsi-makefile-cleanup branch November 7, 2019 06:42
@jerryz123 jerryz123 mentioned this pull request Jan 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrisonliew harrisonliew harrisonliew approved these changes

@colinschmidt colinschmidt Awaiting requested review from colinschmidt

Assignees

@abejgonzalez abejgonzalez

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abejgonzalez @harrisonliew