Bump Barstools #332
Merged
Bump Barstools #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidbiancolin It looks like CI is failing on not finding a |
|
Well this is mystifying, how did CI pass before? |
|
@davidbiancolin found the error, unfortunately firesim was reverted in this commit on accident: 443be01. I rebumped FireSim to a new |
|
Alright so the error in the midasexample is a known issue and is resolved here. We have a couple options. Either you can bump to the same commit you used before, or i can pull the test fix out into a separate PR in firesim, we can merge that, and you can bump again. |
|
Fixed the single test case in FireSim and re-bumped according to @davidbiancolin's request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bumping
barstoolsto have a couple of macro-compiler bug fixes and cleanup.