Enforce that macrocompiler passes are done serially #392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you look at the CI, there are multiple points where the
HwachaRocketConfig
fails during a MacroCompiler step with the following:java.lang.NoClassDefFoundError: mdf/macrolib/PortPolarity
: https://circleci.com/gh/ucb-bar/chipyard/12736java.lang.ClassFormatError: Truncated class file
: https://circleci.com/gh/ucb-bar/chipyard/13029I haven't been able to replicate the error (yay non-determinism), but I theorize that this is a problem with 2
sbt
runs on the same binary (e.g. MacroCompiler) running at the same time (since all our CI uses parallelmake
).sbt
seems to only lock at the beginning when looking up things in ivy, so if MacroCompiler is getting compiled twice, it might clobber files?This is a proposed solution by making the MacroCompiler serialized by having an order only dependency (https://www.gnu.org/software/make/manual/html_node/Prerequisite-Types.html) on the harness MacroCompiler pass.
Any thoughts on this?