Rename Config Mixins to Fragments #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather we use the full term "config fragment" every time we refer to it, rather than just "fragment". I think it maker it clearer, and keeps it within the context of configs |
abejgonzalez
changed the title
abejgonzalez
commented
Feb 26, 2020
docs/Generators/IceNet.rst
Outdated
| Then add the ``WithIceNIC`` config mixin to your configuration. This will | ||
| define ``NICKey``, which IceNIC uses to determine its parameters. The mixin | ||
| Then add the ``WithIceNIC`` config fragment to your configuration. This will | ||
| define ``NICKey``, which IceNIC uses to determine its parameters. The fragment |
abejgonzalez
commented
Feb 26, 2020
abejgonzalez
commented
Feb 26, 2020
alonamid
reviewed
Feb 27, 2020
alonamid
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
LGTM (other than the last lonely fragment that's left). Probably worth for FireSim folks to make sure that FireSim docs are consistent as well with this terminology (@sagark @davidbiancolin @alonamid )
Co-Authored-By: alonamid <alonamid@eecs.berkeley.edu>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: other enhancement
Impact: other
Release Notes
This renames all instances of config mixins to fragments to better distinguish between traits/mixins that apply to the
Topand config fragments that make configs.