Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libgloss #508

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Bump libgloss #508

merged 1 commit into from
Apr 9, 2020

Conversation

a0u
Copy link
Member

@a0u a0u commented Apr 9, 2020

Related issue:

Type of change: other enhancement

Impact: software change

Release Notes
Bump libgloss_htif for trap handler support.

@a0u a0u requested a review from alonamid April 9, 2020 04:29
Copy link
Contributor

@alonamid alonamid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a0u a0u merged commit a5144bc into dev Apr 9, 2020
@a0u a0u deleted the libgloss branch April 9, 2020 17:04
@alonamid alonamid mentioned this pull request Apr 9, 2020
@tymcauley
Copy link
Contributor

Should we re-bump libgloss given this new commit?

ucb-bar/libgloss-htif@a88e50f

Or is there more work planned there?

@tymcauley
Copy link
Contributor

@a0u do you want me to open up a new PR with the latest commit from libgloss-htif?

@a0u
Copy link
Member Author

a0u commented Apr 16, 2020

@tymcauley: I've opened one in #516. I was waiting to see if there was more user feedback about the fix before bumping, but I'll take this is as a sign that things are working.

@tymcauley
Copy link
Contributor

Great, thanks @a0u! Ya, before adding in this fix, any attempt to return from a trap resulted in a corrupted stack pointer, but this commit fixes that for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants