Fix bug in verilator Makefile for 'debug' rule #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM. Could you rebase on most recent Chipyard. I would like to see if CI runs on this PR. |
The 'debug' rule is currently cleaning out the non-debug-model directory rather than the debug-model directory. This commit fixes that, and changes both the debug and non-debug rules to use the variables defined for referring to these two model directories.
tymcauley
force-pushed
the
fix-verilator-debug-make
branch
from
9b4c780
to
70f26fe
Compare
Just rebased onto the most recent Looks like the CI system started, but it's blocked, perhaps until a reviewer approves the PR? |
|
I've went ahead and started the CI. |
|
Looks like the CI had some problems? |
|
Gah. This seems to be an issue with how CircleCI deals with secrets. Im pretty sure this is fine. Thanks for the PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'debug' rule is currently cleaning out the non-debug-model directory rather than the debug-model directory. This means a debug-mode build would cause the non-debug-mode build to get cleared out.
This PR fixes that, and changes both the debug and non-debug rules to use the variables defined for referring to these two model directories.
Related issue:
Type of change: other enhancement
Impact: other
Release Notes