Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CI use ScalaTest for FireSim #528

Merged
merged 3 commits into from
Apr 27, 2020
Merged

Make CI use ScalaTest for FireSim #528

merged 3 commits into from
Apr 27, 2020

Conversation

davidbiancolin
Copy link
Contributor

Also:

  • Lengthen timeout for the hetero config test runs
  • Add Ariane to the FireSim CI. Can be removed.

Type of change: other enhancement

Impact: other

@davidbiancolin davidbiancolin force-pushed the firesim-scalatest branch 2 times, most recently from 3d01dde to 7736566 Compare April 26, 2020 20:07
abejgonzalez
abejgonzalez approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the Ariane fix!

@davidbiancolin davidbiancolin merged commit b042886 into dev Apr 27, 2020
@davidbiancolin davidbiancolin deleted the firesim-scalatest branch April 27, 2020 16:51
@alonamid alonamid mentioned this pull request Apr 29, 2020
Closed
@alonamid alonamid mentioned this pull request May 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

Assignees

@davidbiancolin davidbiancolin

Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbiancolin @abejgonzalez