Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dromajo build from build-toolchains.sh #560

Merged
merged 2 commits into from
May 20, 2020
Merged

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented May 20, 2020

Related issue:

Type of change: bug fix

Impact: other

Release Notes
Fixes the Dromajo build in the toolchain script and adds small comments to the generated files made by the init-submodules and build-toolchains script.

@abejgonzalez abejgonzalez self-assigned this May 20, 2020
@jerryz123
Copy link
Contributor

How did this work before....

@jerryz123 jerryz123 self-requested a review May 20, 2020 18:34
@abejgonzalez
Copy link
Contributor Author

The toolchain wasn't getting rebuilt because it was cached. So when I got rid of the cache it exposed this error.

@abejgonzalez abejgonzalez merged commit 6903172 into dev May 20, 2020
@abejgonzalez abejgonzalez deleted the toolchain-fix branch May 20, 2020 18:50
@alonamid alonamid mentioned this pull request May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants