Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all non-synthesizable constructs into the test harness #572

Merged
merged 2 commits into from
May 27, 2020
Merged

Move all non-synthesizable constructs into the test harness #572

merged 2 commits into from
May 27, 2020

Conversation

colinschmidt
Copy link
Contributor

Type of change: bug fix

Impact: rtl change

Release Notes
Move all non-synthesizable constructs and models into the test harness and out of ChipTop

jwright6323
jwright6323 reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@jwright6323 jwright6323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more or less what I expected. I have a couple questions, though.

generators/chipyard/src/main/scala/config/RocketConfigs.scala Outdated Show resolved Hide resolved
generators/chipyard/src/main/scala/IOBinders.scala Show resolved Hide resolved
jwright6323
jwright6323 approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@jwright6323 jwright6323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @abejgonzalez ?

abejgonzalez
abejgonzalez approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abejgonzalez abejgonzalez merged commit b554b3a into dev May 27, 2020
@alonamid alonamid mentioned this pull request May 30, 2020
Merged
@jerryz123 jerryz123 mentioned this pull request Jul 7, 2020
Closed
@jerryz123 jerryz123 deleted the make-chiptop-synthesizable branch October 1, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryz123 jerryz123 jerryz123 left review comments

@davidbiancolin davidbiancolin davidbiancolin left review comments

@abejgonzalez abejgonzalez abejgonzalez approved these changes

@jwright6323 jwright6323 jwright6323 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@colinschmidt @jwright6323 @davidbiancolin @abejgonzalez @jerryz123