Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dramsim_ini folder to be set at the command line #598

Merged
merged 1 commit into from
Jun 6, 2020

Conversation

colinschmidt
Copy link
Contributor

verilator supports the amount of vpi we need to do our own argument parsing without messing with emulator.cc every time.

Copy link
Contributor

@davidbiancolin davidbiancolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. LGTM

Copy link
Contributor

@jwright6323 jwright6323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Is there even a difference between this and rocket-chip's emulator.cc now?

@colinschmidt
Copy link
Contributor Author

Rocket-chip doesn't support permissive (so doesn't support arbitrarty additions or verilator runtime arguments), it also doesn't support TSI.
We could probably crib the way they do async reset rising pulse, and then it would be a smaller diff but ours still adds several useful features for chipyard.

@colinschmidt colinschmidt merged commit 5e0b3c3 into dev Jun 6, 2020
@colinschmidt colinschmidt deleted the move-dramsim-ini-dir branch June 6, 2020 14:58
@alonamid alonamid mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants