Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parallel hammer simulations #600

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Conversation

colinschmidt
Copy link
Contributor

Type of change: new feature

Impact: software change

Release Notes
Enable parallel simulations in hammer

Bumps hammer and its plugins
Updates to makefile for running simulations without BINARY
Enables make power-par to automatically connect from sim-par
@colinschmidt
Copy link
Contributor Author

This is ready for review.
The chipyard changes are just to allow the user to use Hammer's yaml input directly and not override those keys based on BINARY when its empty.

Copy link
Contributor

@jwright6323 jwright6323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you try to run power with no BINARY?

@colinschmidt
Copy link
Contributor Author

If the user doesn't supply any Hammer yaml to set inputs to sim and doesn't set BINARY sim will just run the simulator with no input which in chipyard just quickly ends the simulation when FESVR detects no binary.
If the user doesn't supply any of the above and runs power the tool will just give static power reports. The current makefile generation in hammer doesn't directly support running power without running sim first, but the user can do this with a redo-power-par and setting the appropriate yaml keys.

@colinschmidt colinschmidt merged commit ad4d7dd into dev Jun 11, 2020
@colinschmidt colinschmidt deleted the enable_parallel_hammer_sims branch June 11, 2020 18:21
@alonamid alonamid mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants