Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sodor Integration #648

Merged
merged 37 commits into from
Oct 2, 2020
Merged

Sodor Integration #648

merged 37 commits into from
Oct 2, 2020

Conversation

zitaofang
Copy link
Member

@zitaofang zitaofang commented Aug 17, 2020

Also, see ucb-bar/riscv-sodor#56.

Related issue: N/A

Type of change: new feature

Impact: rtl change

Release Notes

  • Allow default test suite function to exclude M-extension test suite if the core indicates that it does not have the hardware
  • Add Sodor cores to Chipyard

@zitaofang
Copy link
Member Author

Currently, 1-stage and 5-stage cores are working.

@jerryz123
Copy link
Contributor

The Sodor submodule should be added to the check-submodule-on-master script.

@alonamid alonamid requested a review from a0u August 17, 2020 20:09
sims/verilator/Makefile Outdated Show resolved Hide resolved
build.sbt Show resolved Hide resolved
@jerryz123
Copy link
Contributor

Chipyard-level changes look great. One remaining item is to add the sodor repo to the scripts/check-commit.sh. That script checks that references to submodules exist on the master branches of the submodule repositories, which helps us avoid submodule initialization issues.

@zitaofang zitaofang changed the title [WIP] Sodor Integration Sodor Integration Sep 19, 2020
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/defaults.sh Outdated Show resolved Hide resolved
@jerryz123
Copy link
Contributor

Please add sodor to this line:

submodules=("ariane" "boom" "gemmini" "hwacha" "icenet" "nvdla" "rocket-chip" "sha3" "sifive-blocks" "sifive-cache" "testchipip")

@zitaofang
Copy link
Member Author

Waiting for ucb-bar/testchipip#102 to be merged.

.circleci/check-commit.sh Outdated Show resolved Hide resolved
@jerryz123 jerryz123 self-requested a review October 2, 2020 00:30
@jerryz123 jerryz123 merged commit 2db3c90 into dev Oct 2, 2020
@zitaofang zitaofang deleted the sodor-integrate branch October 9, 2020 06:11
@alonamid alonamid mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants