Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo regression in iocells flexibility #674

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Undo regression in iocells flexibility #674

merged 1 commit into from
Sep 15, 2020

Conversation

jerryz123
Copy link
Contributor

Related issue:

Type of change: bug fix

jwright6323
jwright6323 approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@jwright6323 jwright6323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, but I don't really know how the FireSim IO cells work at all. How do they handle the Analogs?

@jerryz123
Copy link
Contributor Author

This seems fine to me, but I don't really know how the FireSim IO cells work at all. How do they handle the Analogs?

The don't. If you build a design with analog IOs, the require in trait Unsupported will complain that its unsupported.

@jwright6323
Copy link
Contributor

Oh, I forgot the pad signal is not an Analog for inputs/outputs. Sounds good.

@jerryz123 jerryz123 merged commit 23a199e into dev Sep 15, 2020
@jerryz123 jerryz123 deleted the iocells-fix branch September 17, 2020 22:18
@alonamid alonamid mentioned this pull request Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwright6323 jwright6323 jwright6323 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryz123 @jwright6323