Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of --ignore-qemu option #791

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Fix parsing of --ignore-qemu option #791

merged 1 commit into from
Feb 10, 2021

Conversation

a0u
Copy link
Member

@a0u a0u commented Feb 9, 2021 •
edited
Loading

Related issue:

Type of change: bug fix

Impact: other

Release Notes

Remove an extra shift that breaks parsing of subsequent arguments. The positional parameters are already shifted once at the end of the loop body.

@a0u a0u requested a review from abejgonzalez February 9, 2021 21:10
abejgonzalez
abejgonzalez approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. LGTM pending CI

@a0u a0u merged commit c995194 into dev Feb 10, 2021
@a0u a0u deleted the ignore-qemu branch February 10, 2021 05:21
@alonamid alonamid mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a0u @abejgonzalez