Fix TileResetCtrl to be ahead of reset synchronizers. #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the TileResetCtrl registers to be ahead of the reset synchronizers. The TileResetCtrl registers emit an async reset that a downstream synchronizer should catch and sync.
Additionally, this gives the TileResetCtrl registers the async reset coming directly from ChipTop, through a new AsyncResetBroadcast mini network.
While in theory the ChipTop async reset can be broadcast through the same diplomacy graph as the clocks, I think that approach is a bit confusing. When we expect the async reset to be coming directly from ChipTop, the code should make it clear that that is what is happening.
Type of change: bug fix
Impact: rtl change