Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory alignment in character count RoCC test #853

Merged
merged 3 commits into from
Apr 9, 2021

Conversation

alfonrod
Copy link
Contributor

@alfonrod alfonrod commented Apr 9, 2021

The character count RoCC accelerator performs aligned (CacheBlockBytes) TL accesses to get input data. However, the test application does not enforce such alignment, and the accelerator may end up processing values outside the input string. If this happens and a '\0' is detected before the actual string starts, the accelerator sets its finished flag and returns a wrong result.

Related issue: #839

Type of change: bug fix

Impact: software change

Release Notes

@jerryz123 jerryz123 changed the base branch from master to dev April 9, 2021 18:54
@jerryz123
Copy link
Contributor

Changing base branch to dev

@jerryz123
Copy link
Contributor

Thanks for catching and fixing this

@jerryz123 jerryz123 merged commit 440e43d into ucb-bar:dev Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants