Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate rocket-dsp-utils (formerly dsptools/rocket subproject) #888

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

chick
Copy link
Collaborator

@chick chick commented Jun 9, 2021

  • Add submodules
    • api-config-chipsalliance
    • rocket-dsp-utils
  • update check-commit.sh to include rocket-dsp-utils
  • changes to build.sbt
    • change rocket-dsptools to rocket-dp-utils
    • add api-config-chipsalliance

Related issue:

Type of change: Enhancement

Impact: Support for additional dsp utilities

Release Notes
Provides access to former dsptools/rocket utilities now named ucb-bar/rocket-dsp-utils

  - api-config-chipsalliance
  - rocket-dsp-utils
- update check-commit.sh to include rocket-dsp-utils
- changes to build.sbt
  - change rocket-dsptools to rocket-dp-utils
  - add api-config-chipsalliance
@chick chick added DO NOT MERGE cleanup dependencies Pull requests that update a dependency file labels Jun 9, 2021
@chick chick self-assigned this Jun 9, 2021
@chick chick added release and removed DO NOT MERGE labels Jun 9, 2021
@chick chick changed the title - Add submodules Integrate rocket-dsp-utils (formerly dsptools/rocket subproject) Jun 9, 2021
@chick chick requested a review from alonamid June 9, 2021 17:03
@alonamid
Copy link
Contributor

alonamid commented Jun 9, 2021

Does anything need to change in the docs here? I looked over the only page I believe was relevant and I did not see anything that I thought needed to change, but probably worth confirming again

@alonamid
Copy link
Contributor

alonamid commented Jun 9, 2021

Also, looks like this need to fix the tutorial patch for build.sbt

`rocket-dsptools` to `rocket-dsp-utils`
Copy link
Contributor

@alonamid alonamid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alonamid alonamid merged commit 946cad0 into dev Jun 10, 2021
@jerryz123 jerryz123 deleted the add-rocket-dsp-utils branch October 1, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup dependencies Pull requests that update a dependency file release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants