Refactor code and add fixes for binary point edge cases #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace pattern matching with function calls where sensible * Remove superfluous use of asSInt * Minimize the use of _inferredBinaryPoint * Add source info to asFixedPoint
* Disallow negative binary point * Ensure that floor, ceil, and round don't change width or binary point * Don't force width in setBinaryPoint since binary point difference can be greater than data width * Add test cases for when binary point is greater than or equal to width
konda-x1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixedPointmethods have been rewritten to be more comprehensible.connectwhen the binary point difference between sink and source is larger than the source's data width.floor,ceil, andround, particularly when binary point is greater than or equal to width.FixedPoint.