Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for deprecation. #30

Merged
merged 1 commit into from
Jan 17, 2022
Merged

fix for deprecation. #30

merged 1 commit into from
Jan 17, 2022

Conversation

sequencer
Copy link
Contributor

No description provided.

@sequencer
Copy link
Contributor Author

@jerryz123 Hi, Jerry, would you mind reviewing this PR? This is a strict forward PR to remove APIs which has been deleted from Chisel 3.5, wanna get this repository been able to be complied in Chisel 3.5.

colinschmidt
colinschmidt approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sequencer
Copy link
Contributor Author

How can we get this in after approved? ;p

@abejgonzalez abejgonzalez changed the base branch from master to chisel-3.5-bump January 17, 2022 22:48
@abejgonzalez abejgonzalez merged commit 062e46e into ucb-bar:chisel-3.5-bump Jan 17, 2022
@abejgonzalez abejgonzalez mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig left review comments

@colinschmidt colinschmidt colinschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sequencer @colinschmidt @jackkoenig @abejgonzalez