Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new C++ compilers. #42

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Support new C++ compilers. #42

merged 1 commit into from
Oct 30, 2018

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented Oct 11, 2018

Use official C++ includes.
Use std::string.

@ucbjrl
Support new C++ compilers.
e6bbb78 
Use official C++ includes.
Use std::string.
edwardcwang
edwardcwang approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@edwardcwang edwardcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me but we should check with @ccelio

@ucbjrl
Copy link
Contributor Author

ucbjrl commented Oct 12, 2018

This also fixes #37

@ucbjrl ucbjrl mentioned this pull request Oct 30, 2018
Open
@ccelio ccelio merged commit 51c54e9 into master Oct 30, 2018
@edwardcwang edwardcwang mentioned this pull request Oct 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardcwang edwardcwang edwardcwang approved these changes

@ccelio ccelio Awaiting requested review from ccelio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ucbjrl @edwardcwang @ccelio