Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to stop specific version of served model ? #601

Closed
YupaTapuY opened this issue Nov 30, 2018 · 6 comments
Closed

How to stop specific version of served model ? #601

YupaTapuY opened this issue Nov 30, 2018 · 6 comments

Comments

@YupaTapuY
Copy link

No description provided.

@YupaTapuY
Copy link
Author

is there a function that can stop a served model container for specific version, not stop a whole model ?

@withsmilo
Copy link
Collaborator

withsmilo commented Nov 30, 2018

@YupaTapuY :
I have implemented the function already, but not created it as a PR yet.

@withsmilo
Copy link
Collaborator

withsmilo commented Nov 30, 2018

I'm so sorry about my wrong comment. You can use this API to stop versioned models,

https://github.com/ucbrise/clipper/blob/develop/clipper_admin/clipper_admin/clipper_admin.py#L1194-L1218

clipper_conn.stop_versioned_models({
            "model_1": ["ver_1"],
            "model_2": ["ver_1", "ver_2"],
        })

Please note, however, that this API ONLY deletes them from Docker Orchestration, not Clipper internal.

@avinregmi
Copy link

@withsmilo I'm having trouble deleting the model from clipper internal. Is there a way to delete models from clipper internal redis? I've tried deleting application it is linked to but when i'm using get_all_models() it still shows up there even if it does not exist in k8s.

@withsmilo
Copy link
Collaborator

@avinregmi : My suggestion for API scheme improvement is #603 and current status is here,

  • unlink_model_from_app API : implemented but not pull-requested yet.
  • unregister_versioned_models API : implemented and pull-requested already. (Implement delete_versioned_model API #602)
  • Rename delete_application to unregister_application : implemented but not pull-requested yet.

@withsmilo
Copy link
Collaborator

resolved by #603.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants