Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion - API scheme improvement #603

Closed
4 tasks done
withsmilo opened this issue Dec 4, 2018 · 1 comment
Closed
4 tasks done

Suggestion - API scheme improvement #603

withsmilo opened this issue Dec 4, 2018 · 1 comment
Assignees
@withsmilo
Labels
type: enhancement

Comments

@withsmilo
Copy link
Collaborator

withsmilo commented Dec 4, 2018 •
edited
Loading

Current Clipper provides the following clipper_admin APIs in Python level, but I think that some additional APIs will have to be implemented to maintain Clipper cluster.

  • Add unlink_model_from_app, which unlinks specified model from specified application.
  • Add unregister_versioned_models, which unregisters versioned models from Clipper Internal (remove all related resources as like working threads and queues also).
  • Add unregister_application to keep consistency with others.
  • Mark delete_application deprecated, but must be redirected to unregister_application.

clipper_admin_api
@withsmilo withsmilo mentioned this issue Dec 4, 2018
Merged
4 tasks
@withsmilo withsmilo mentioned this issue Feb 14, 2019
Closed
withsmilo pushed a commit to withsmilo/clipper that referenced this issue Mar 22, 2019
Rename 'delete_application' to 'unregister_application' in clipper_admin
4cafb80 
* related issue : ucbrise#603
@withsmilo withsmilo mentioned this issue Mar 22, 2019
Merged
withsmilo pushed a commit to withsmilo/clipper that referenced this issue Mar 22, 2019
Implement delete_model_links API
d008c04 
* related issue : ucbrise#603
* Delete the link between a model and an app.

> Description
> -----------
> unlink_model_from_app(app_name, model_name)

> Parameters
> ----------
> app_name : str
>     The name of the application
> model_name : str
>     The name of the model to link to the application

> Raises
> ------
> :py:exc:`clipper.UnconnectedException`
>     versions. All replicas for each version of each model will be stopped.

> API path
> --------
> POST /admin/delete_model_links

> Request schema
> --------------
> const std::string DELETE_MODEL_LINKS_JSON_SCHEMA = R"(
>   {
>   "app_name" := string,
>   "model_names" := [string]
>   }
> )";
withsmilo pushed a commit to withsmilo/clipper that referenced this issue Mar 22, 2019
Implement delete_model_links API
9280d66 
* related issue : ucbrise#603
* Delete the link between a model and an app.
* Implemented `unlink_model_from_app` Clipper API in clipper_admin.

> Description
> -----------
> unlink_model_from_app(app_name, model_name)

> Parameters
> ----------
> app_name : str
>     The name of the application
> model_name : str
>     The name of the model to link to the application

> Raises
> ------
> :py:exc:`clipper.UnconnectedException`
>     versions. All replicas for each version of each model will be stopped.

* Implemented `delete_model_links` Management-Frontend API.

> API path
> --------
> POST /admin/delete_model_links

> Request schema
> --------------
> const std::string DELETE_MODEL_LINKS_JSON_SCHEMA = R"(
>   {
>   "app_name" := string,
>   "model_names" := [string]
>   }
> )";
@withsmilo withsmilo mentioned this issue Mar 22, 2019
Merged
simon-mo pushed a commit that referenced this issue Mar 28, 2019
@simon-mo
Implement delete_model_links API (#654)
e1990f7 
* Implement delete_model_links API

* related issue : #603
* Delete the link between a model and an app.
* Implemented `unlink_model_from_app` Clipper API in clipper_admin.

> Description
> -----------
> unlink_model_from_app(app_name, model_name)

> Parameters
> ----------
> app_name : str
>     The name of the application
> model_name : str
>     The name of the model to link to the application

> Raises
> ------
> :py:exc:`clipper.UnconnectedException`
>     versions. All replicas for each version of each model will be stopped.

* Implemented `delete_model_links` Management-Frontend API.

> API path
> --------
> POST /admin/delete_model_links

> Request schema
> --------------
> const std::string DELETE_MODEL_LINKS_JSON_SCHEMA = R"(
>   {
>   "app_name" := string,
>   "model_names" := [string]
>   }
> )";

* Fix build error in redis_test.cpp

* Decrease test samples for test_stop_models case
@withsmilo withsmilo self-assigned this Apr 1, 2019
rkooo567 pushed a commit to rkooo567/clipper that referenced this issue Apr 27, 2019
@rkooo567
Implement delete_model_links API (ucbrise#654)
4f137aa 
* Implement delete_model_links API

* related issue : ucbrise#603
* Delete the link between a model and an app.
* Implemented `unlink_model_from_app` Clipper API in clipper_admin.

> Description
> -----------
> unlink_model_from_app(app_name, model_name)

> Parameters
> ----------
> app_name : str
>     The name of the application
> model_name : str
>     The name of the model to link to the application

> Raises
> ------
> :py:exc:`clipper.UnconnectedException`
>     versions. All replicas for each version of each model will be stopped.

* Implemented `delete_model_links` Management-Frontend API.

> API path
> --------
> POST /admin/delete_model_links

> Request schema
> --------------
> const std::string DELETE_MODEL_LINKS_JSON_SCHEMA = R"(
>   {
>   "app_name" := string,
>   "model_names" := [string]
>   }
> )";

* Fix build error in redis_test.cpp

* Decrease test samples for test_stop_models case
rkooo567 pushed a commit to rkooo567/clipper that referenced this issue Apr 28, 2019
@rkooo567
Implement delete_model_links API (ucbrise#654)
290a068 
* Implement delete_model_links API

* related issue : ucbrise#603
* Delete the link between a model and an app.
* Implemented `unlink_model_from_app` Clipper API in clipper_admin.

> Description
> -----------
> unlink_model_from_app(app_name, model_name)

> Parameters
> ----------
> app_name : str
>     The name of the application
> model_name : str
>     The name of the model to link to the application

> Raises
> ------
> :py:exc:`clipper.UnconnectedException`
>     versions. All replicas for each version of each model will be stopped.

* Implemented `delete_model_links` Management-Frontend API.

> API path
> --------
> POST /admin/delete_model_links

> Request schema
> --------------
> const std::string DELETE_MODEL_LINKS_JSON_SCHEMA = R"(
>   {
>   "app_name" := string,
>   "model_names" := [string]
>   }
> )";

* Fix build error in redis_test.cpp

* Decrease test samples for test_stop_models case
rkooo567 pushed a commit to rkooo567/clipper that referenced this issue Apr 28, 2019
@rkooo567
Implement delete_model_links API (ucbrise#654)
1ab16d5 
* Implement delete_model_links API

* related issue : ucbrise#603
* Delete the link between a model and an app.
* Implemented `unlink_model_from_app` Clipper API in clipper_admin.

> Description
> -----------
> unlink_model_from_app(app_name, model_name)

> Parameters
> ----------
> app_name : str
>     The name of the application
> model_name : str
>     The name of the model to link to the application

> Raises
> ------
> :py:exc:`clipper.UnconnectedException`
>     versions. All replicas for each version of each model will be stopped.

* Implemented `delete_model_links` Management-Frontend API.

> API path
> --------
> POST /admin/delete_model_links

> Request schema
> --------------
> const std::string DELETE_MODEL_LINKS_JSON_SCHEMA = R"(
>   {
>   "app_name" := string,
>   "model_names" := [string]
>   }
> )";

* Fix build error in redis_test.cpp

* Decrease test samples for test_stop_models case
withsmilo pushed a commit that referenced this issue May 12, 2019
Rename 'delete_application' to 'unregister_application' in clipper_ad…
8051a4e 
…min (#653)

* Rename 'delete_application' to 'unregister_application' in clipper_admin

* related issue : #603

* Old API(delete_application) is redirected to new API(unregister_application)
@withsmilo
Copy link
Collaborator Author

All the APIs are implemented. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@withsmilo withsmilo

Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@withsmilo