Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python container to correctly run "pip install cryptography" #243

Merged
merged 5 commits into from
Jul 6, 2017

Conversation

dcrankshaw
Copy link
Contributor

If the user has a version of the cryptography library installed with pip, this change allows the model container to build it from source as the pip package requires. The cryptography library has C extensions, so it requires a compiler to build it.

In particular, this case is important to support because the clipper_admin pip package installs the cryptography as a dependency (by way of the fabric dependency).

@dcrankshaw dcrankshaw self-assigned this Jun 30, 2017
@dcrankshaw dcrankshaw requested a review from nishadsingh1 June 30, 2017 05:00
@dcrankshaw dcrankshaw changed the title Fix python container deps Update Python container to correctly run pip install cryptography Jun 30, 2017
@dcrankshaw dcrankshaw changed the title Update Python container to correctly run pip install cryptography Update Python container to correctly run "pip install cryptography" Jun 30, 2017
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/508/
Test PASSed.

@nishadsingh1
Copy link

Checking this now. Also, is there a reason we don't preinstall clipper_admin? We could make a preinstalled pip package list whose elements we install after the conda ones.

Copy link
Contributor

@Corey-Zumar Corey-Zumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/509/
Test FAILed.

@dcrankshaw
Copy link
Contributor Author

jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/510/
Test FAILed.

@Corey-Zumar
Copy link
Contributor

jenkins test this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/514/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/517/
Test PASSed.

@Corey-Zumar Corey-Zumar merged commit 350ed1c into ucbrise:develop Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants