-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python container to correctly run "pip install cryptography" #243
Update Python container to correctly run "pip install cryptography" #243
Conversation
Test PASSed. |
Checking this now. Also, is there a reason we don't preinstall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test FAILed. |
jenkins test this please |
Test FAILed. |
jenkins test this please |
Test PASSed. |
Test PASSed. |
If the user has a version of the cryptography library installed with pip, this change allows the model container to build it from source as the pip package requires. The cryptography library has C extensions, so it requires a compiler to build it.
In particular, this case is important to support because the
clipper_admin
pip package installs the cryptography as a dependency (by way of the fabric dependency).