Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed redis cli in favor of clipper.get_model_info #260

Merged
merged 2 commits into from
Jul 28, 2017
Merged

Removed redis cli in favor of clipper.get_model_info #260

merged 2 commits into from
Jul 28, 2017

Conversation

rmdort
Copy link
Contributor

@rmdort rmdort commented Jul 26, 2017 •
edited by dcrankshaw
Loading

Resolves #259

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@dcrankshaw
Copy link
Contributor

jenkins okay to test

@dcrankshaw dcrankshaw mentioned this pull request Jul 28, 2017
Closed
dcrankshaw
dcrankshaw approved these changes Jul 28, 2017
View reviewed changes
Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once the tests pass I'll merge this.

@dcrankshaw
Copy link
Contributor

jenkins ok to test

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/596/
Test FAILed.

@dcrankshaw
Copy link
Contributor

Looks like you need to fix the python formatting. Run ./bin/format_code.sh.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/597/
Test PASSed.

@dcrankshaw dcrankshaw merged commit e34e424 into ucbrise:develop Jul 28, 2017
@dcrankshaw
Copy link
Contributor

@rmdort There are a couple more small changes I need to make first, but I'll push a new release of clipper_admin to PyPi this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcrankshaw dcrankshaw dcrankshaw approved these changes

Assignees
No one assigned
Labels
status: accepted type: maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmdort @AmplabJenkins @dcrankshaw