-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make unit tests run in a Docker container #274
Conversation
97d8383
to
53258a6
Compare
You can run the unit tests with the following command:
|
Test FAILed. |
jenkins test this please |
1 similar comment
jenkins test this please |
Test PASSed. |
Test FAILed. |
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -1,40 +1,17 @@ | |||
FROM frolvlad/alpine-gxx | |||
FROM ubuntu:16.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From an ease of development standpoint, this change of base image is a plus. Any concerns about the difference in image size and overhead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not at this point. We can always build a minimal size docker image on alpine in the future. But that doesn't seem super important right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo there shouldn't really be any since this is a base file used for frontend containers that we won't be replicating as frequently as model containers. Merging...
This adds a Docker container that can run all of our unit tests. In order to make this work, I also had to switch the base image for the query and management frontends from alpine to ubuntu. Other than increasing image size, this should not be a noticeable change.