Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes readthedocs documentation #278

Merged
merged 9 commits into from
Sep 2, 2017
Merged

Fixes readthedocs documentation #278

merged 9 commits into from
Sep 2, 2017

Conversation

dcrankshaw
Copy link
Contributor

Fixes #277. Readthedocs was having issues installing all the Clipper dependencies. Solved by adding a requirements.txt file and mocking out PySpark (based on this FAQ answer).

The rebuilt documentation is here: http://docs.clipper.ai/en/check-rtd-build/ (compare to http://docs.clipper.ai/en/develop/).

@dcrankshaw dcrankshaw added this to the 0.2 Release milestone Sep 1, 2017
@dcrankshaw dcrankshaw self-assigned this Sep 1, 2017
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/673/
Test FAILed.

Corey-Zumar
Corey-Zumar approved these changes Sep 1, 2017
View reviewed changes
Copy link
Contributor

@Corey-Zumar Corey-Zumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge once code passes tests, looks like there's a formatting issue

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/680/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/687/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/688/
Test PASSed.

@dcrankshaw dcrankshaw merged commit 781a398 into develop Sep 2, 2017
@dcrankshaw dcrankshaw deleted the check-rtd-build branch September 2, 2017 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corey-Zumar Corey-Zumar Corey-Zumar approved these changes

Assignees

@dcrankshaw dcrankshaw

Labels
status: accepted type: documentation
Projects
None yet
Milestone
0.2 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@dcrankshaw @AmplabJenkins @Corey-Zumar