Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick up kube credentials from env variables for k8s integration test #284

Merged
merged 8 commits into from
Sep 4, 2017
Merged

Pick up kube credentials from env variables for k8s integration test #284

merged 8 commits into from
Sep 4, 2017

Conversation

dcrankshaw
Copy link
Contributor

Fixes #276

This should be the last PR needed for the 0.2 release.

Have a release taco 🌮 🌮 🌮 !!

@dcrankshaw dcrankshaw added this to the 0.2 Release milestone Sep 3, 2017
@dcrankshaw dcrankshaw self-assigned this Sep 3, 2017
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/696/
Test FAILed.

@dcrankshaw
Copy link
Contributor Author

jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/697/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/698/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/699/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/700/
Test PASSed.

Corey-Zumar
Corey-Zumar approved these changes Sep 3, 2017
View reviewed changes
Copy link
Contributor

@Corey-Zumar Corey-Zumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Release taco inbound! 🎆 🌮 🎉 🌮

bin/ci_checks.sh Outdated
@@ -16,8 +23,25 @@ tag=$(<VERSION.txt)
cd -

# Test docker login
docker pull 568959175238.dkr.ecr.us-west-1.amazonaws.com/clipper/query_frontend:$tag
# docker pull 568959175238.dkr.ecr.us-west-1.amazonaws.com/clipper/query_frontend:$tag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed or uncommented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncommented

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/701/
Test PASSed.

@dcrankshaw dcrankshaw merged commit 66f4aca into ucbrise:develop Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corey-Zumar Corey-Zumar Corey-Zumar approved these changes

Assignees

@dcrankshaw dcrankshaw

Labels
status: accepted type: maintenance
Projects
None yet
Milestone
0.2 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@dcrankshaw @AmplabJenkins @Corey-Zumar