Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric Monitoring: Set Prometheus Version Tag #384

Merged
merged 38 commits into from
Feb 4, 2018

Conversation

simon-mo
Copy link
Contributor

@simon-mo simon-mo commented Jan 30, 2018

Fixes #383

Also sneak in the new example for monitoring.

simon-mo and others added 30 commits January 14, 2018 00:50
This commit adds an example in the example folder. It helps
the user to visualize clipper metric.

The init_grafana.py script launches a grafana/grafana docker
container. It adds prometheus as a data source. I attempted
to add the dashboard via Grafana API but failed after trying
it out for hours. This seems like a persistent issue for at
least two years: grafana/grafana#2816

<Simon Mo>
This commit adds an example in the example folder. It helps
the user to visualize clipper metric.

The init_grafana.py script launches a grafana/grafana docker
container. It adds prometheus as a data source. I attempted
to add the dashboard via Grafana API but failed after trying
it out for hours. This seems like a persistent issue for at
least two years: grafana/grafana#2816

<Simon Mo>
1. Fix naming and typos
2. Update configuration buckets
- use 1000.0 instead 1000 rpc arithmatic.
- change docs
Add a block of code make sure config file is found.
@simon-mo simon-mo requested a review from dcrankshaw January 30, 2018 16:28
@simon-mo simon-mo self-assigned this Jan 30, 2018
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/920/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/921/
Test PASSed.

Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change the tag to the latest released version and this is good to go

@@ -4,6 +4,8 @@
import os
from ..version import __version__

PROM_VERSION = "master"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the latest release (v2.1.0) instead of master

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha that was my in first commit but I changed it, I'll update it

Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/924/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/926/
Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants