-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric Monitoring: Set Prometheus Version Tag #384
Conversation
This commit adds an example in the example folder. It helps the user to visualize clipper metric. The init_grafana.py script launches a grafana/grafana docker container. It adds prometheus as a data source. I attempted to add the dashboard via Grafana API but failed after trying it out for hours. This seems like a persistent issue for at least two years: grafana/grafana#2816 <Simon Mo>
This commit adds an example in the example folder. It helps the user to visualize clipper metric. The init_grafana.py script launches a grafana/grafana docker container. It adds prometheus as a data source. I attempted to add the dashboard via Grafana API but failed after trying it out for hours. This seems like a persistent issue for at least two years: grafana/grafana#2816 <Simon Mo>
1. Fix naming and typos 2. Update configuration buckets
- use 1000.0 instead 1000 rpc arithmatic. - change docs
Add a block of code make sure config file is found.
Test FAILed. |
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just change the tag to the latest released version and this is good to go
@@ -4,6 +4,8 @@ | |||
import os | |||
from ..version import __version__ | |||
|
|||
PROM_VERSION = "master" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the latest release (v2.1.0
) instead of master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha that was my in first commit but I changed it, I'll update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test PASSed. |
Test PASSed. |
Fixes #383
Also sneak in the new example for monitoring.