Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose http configurations to clipper_admin #524

Merged
merged 7 commits into from
Apr 1, 2019

Conversation

withsmilo
Copy link
Collaborator

@withsmilo withsmilo commented Jun 25, 2018

  • solved: Increase thread pool size in query front end #523
  • exposed configurations
    • qf_http_thread_pool_size
      • int(optional)
      • The size of thread pool created in query frontend for http serving.
    • qf_http_timeout_request
      • int(optional)
      • The seconds of timeout on request handling in query frontend for http serving.
    • qf_http_timeout_content
      • int(optional)
      • The seconds of timeout on content handling in query frontend for http serving.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@simon-mo
Copy link
Contributor

simon-mo commented Jul 1, 2018

@withsmilo Thanks for the PR. These changes are great.

I think we should expose these parameters but directly expose them at start_clipper seems to be too much.

Maybe in start_clipper, we can add an option field instead of three separate arguments:

     qf_options: (dict) extra configuration parameters for query frontend

My main concern is simply the usability and simplicity of our python API.

@dcrankshaw What's your thought on this?

@simon-mo
Copy link
Contributor

simon-mo commented Jul 1, 2018

jenkins test this please

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@withsmilo
Copy link
Collaborator Author

@simon-mo
Great suggestion! qf_options must contain the following parameters in start_clipper.

  • cache_size
  • http_thread_pool_size
  • http_timeout_request
  • http_timeout_content
  • num_replicas (renamed from num_frontend_replicas)

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1624/
Test FAILed.

@withsmilo
Copy link
Collaborator Author

@simon-mo, @dcrankshaw :
How about this?

def start_clipper(self,
                      query_frontend_image,
                      mgmt_frontend_image,
                      frontend_exporter_image,
                      cache_size,
                      num_frontend_replicas,
                      qf_http_options=None):

    # qf_http_options: (dict) extra http configuration parameters for query frontend

    default_qf_http_options = {
        "http_thread_pool_size" : 1,
        "http_timeout_request" : 5,
        "http_timeout_content" : 300
    }

    if qf_http_options is not None and type(qf_http_options) is dict:
        default_qf_http_options.update(qf_http_options)

@withsmilo
Copy link
Collaborator Author

Jenkins test this please

@withsmilo withsmilo requested a review from simon-mo January 29, 2019 15:41
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1780/
Test FAILed.

@withsmilo
Copy link
Collaborator Author

Jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1781/
Test FAILed.

@withsmilo
Copy link
Collaborator Author

Jenkins ok to test

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1823/
Test FAILed.

* solved: ucbrise#523
* exposed configurations
  * qf_http_thread_pool_size
    * int(optional)
    * The size of thread pool created in query frontend for http serving.
  * qf_http_timeout_request
    * int(optional)
    * The seconds of timeout on request handling in query frontend for http serving.
  * qf_http_timeout_content
    * int(optional)
    * The seconds of timeout on content handling in query frontend for http serving.
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1855/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1862/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1867/
Test FAILed.

@withsmilo
Copy link
Collaborator Author

Jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1868/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1870/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1874/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1879/
Test PASSed.

@simon-mo simon-mo merged commit 71e7e3b into ucbrise:develop Apr 1, 2019
@withsmilo withsmilo deleted the expose_http_conf branch April 1, 2019 20:03
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 27, 2019
* Expose http configurations to clipper_admin

* solved: ucbrise#523
* exposed configurations
  * qf_http_thread_pool_size
    * int(optional)
    * The size of thread pool created in query frontend for http serving.
  * qf_http_timeout_request
    * int(optional)
    * The seconds of timeout on request handling in query frontend for http serving.
  * qf_http_timeout_content
    * int(optional)
    * The seconds of timeout on content handling in query frontend for http serving.

* Fix test cases

* Fix DockerContainerManager
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 28, 2019
* Expose http configurations to clipper_admin

* solved: ucbrise#523
* exposed configurations
  * qf_http_thread_pool_size
    * int(optional)
    * The size of thread pool created in query frontend for http serving.
  * qf_http_timeout_request
    * int(optional)
    * The seconds of timeout on request handling in query frontend for http serving.
  * qf_http_timeout_content
    * int(optional)
    * The seconds of timeout on content handling in query frontend for http serving.

* Fix test cases

* Fix DockerContainerManager
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 28, 2019
* Expose http configurations to clipper_admin

* solved: ucbrise#523
* exposed configurations
  * qf_http_thread_pool_size
    * int(optional)
    * The size of thread pool created in query frontend for http serving.
  * qf_http_timeout_request
    * int(optional)
    * The seconds of timeout on request handling in query frontend for http serving.
  * qf_http_timeout_content
    * int(optional)
    * The seconds of timeout on content handling in query frontend for http serving.

* Fix test cases

* Fix DockerContainerManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants