-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose http configurations to clipper_admin #524
Conversation
withsmilo
commented
Jun 25, 2018
•
edited
Loading
edited
- solved: Increase thread pool size in query front end #523
- exposed configurations
- qf_http_thread_pool_size
- int(optional)
- The size of thread pool created in query frontend for http serving.
- qf_http_timeout_request
- int(optional)
- The seconds of timeout on request handling in query frontend for http serving.
- qf_http_timeout_content
- int(optional)
- The seconds of timeout on content handling in query frontend for http serving.
- qf_http_thread_pool_size
Can one of the admins verify this patch? |
f8d6f42
to
c2cf398
Compare
@withsmilo Thanks for the PR. These changes are great. I think we should expose these parameters but directly expose them at Maybe in start_clipper, we can add an option field instead of three separate arguments:
My main concern is simply the usability and simplicity of our python API. @dcrankshaw What's your thought on this? |
jenkins test this please |
Can one of the admins verify this patch? |
@simon-mo
|
Test FAILed. |
@simon-mo, @dcrankshaw : def start_clipper(self,
query_frontend_image,
mgmt_frontend_image,
frontend_exporter_image,
cache_size,
num_frontend_replicas,
qf_http_options=None):
# qf_http_options: (dict) extra http configuration parameters for query frontend
default_qf_http_options = {
"http_thread_pool_size" : 1,
"http_timeout_request" : 5,
"http_timeout_content" : 300
}
if qf_http_options is not None and type(qf_http_options) is dict:
default_qf_http_options.update(qf_http_options) |
c2cf398
to
901e8de
Compare
Jenkins test this please |
Test FAILed. |
Jenkins test this please |
Test FAILed. |
901e8de
to
b8c502b
Compare
b8c502b
to
11c7f09
Compare
Jenkins ok to test |
Test FAILed. |
* solved: ucbrise#523 * exposed configurations * qf_http_thread_pool_size * int(optional) * The size of thread pool created in query frontend for http serving. * qf_http_timeout_request * int(optional) * The seconds of timeout on request handling in query frontend for http serving. * qf_http_timeout_content * int(optional) * The seconds of timeout on content handling in query frontend for http serving.
11c7f09
to
f981275
Compare
Test FAILed. |
Test FAILed. |
Test FAILed. |
Jenkins test this please |
Test FAILed. |
Test FAILed. |
Test FAILed. |
Test PASSed. |
* Expose http configurations to clipper_admin * solved: ucbrise#523 * exposed configurations * qf_http_thread_pool_size * int(optional) * The size of thread pool created in query frontend for http serving. * qf_http_timeout_request * int(optional) * The seconds of timeout on request handling in query frontend for http serving. * qf_http_timeout_content * int(optional) * The seconds of timeout on content handling in query frontend for http serving. * Fix test cases * Fix DockerContainerManager
* Expose http configurations to clipper_admin * solved: ucbrise#523 * exposed configurations * qf_http_thread_pool_size * int(optional) * The size of thread pool created in query frontend for http serving. * qf_http_timeout_request * int(optional) * The seconds of timeout on request handling in query frontend for http serving. * qf_http_timeout_content * int(optional) * The seconds of timeout on content handling in query frontend for http serving. * Fix test cases * Fix DockerContainerManager
* Expose http configurations to clipper_admin * solved: ucbrise#523 * exposed configurations * qf_http_thread_pool_size * int(optional) * The size of thread pool created in query frontend for http serving. * qf_http_timeout_request * int(optional) * The seconds of timeout on request handling in query frontend for http serving. * qf_http_timeout_content * int(optional) * The seconds of timeout on content handling in query frontend for http serving. * Fix test cases * Fix DockerContainerManager