Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python anti pattern #651

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Fix Python anti pattern #651

merged 2 commits into from
Mar 28, 2019

Conversation

withsmilo
Copy link
Collaborator

@withsmilo withsmilo self-assigned this Mar 21, 2019
@withsmilo withsmilo requested a review from simon-mo March 21, 2019 23:23
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1808/
Test PASSed.

@withsmilo
Copy link
Collaborator Author

@simon-mo , please review this. :)

@withsmilo withsmilo requested a review from RehanSD March 28, 2019 00:31
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1850/
Test PASSed.

@simon-mo simon-mo merged commit a7e65f2 into ucbrise:develop Mar 28, 2019
@withsmilo withsmilo deleted the fix_anti_pattern branch March 28, 2019 12:18
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 27, 2019
@rkooo567
Fix Python anti pattern (ucbrise#651)
381ec2a 
* related issue : ucbrise#650
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 28, 2019
@rkooo567
Fix Python anti pattern (ucbrise#651)
000f779 
* related issue : ucbrise#650
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 28, 2019
@rkooo567
Fix Python anti pattern (ucbrise#651)
a2d5408 
* related issue : ucbrise#650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

@RehanSD RehanSD Awaiting requested review from RehanSD

Assignees

@withsmilo withsmilo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@withsmilo @AmplabJenkins @simon-mo