Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add retry-routine to 'docker push' in clipper_docker.cfg.py #655

Merged
merged 4 commits into from
Mar 28, 2019
Merged

[CI] Add retry-routine to 'docker push' in clipper_docker.cfg.py #655

merged 4 commits into from
Mar 28, 2019

Conversation

withsmilo
Copy link
Collaborator

@withsmilo withsmilo commented Mar 25, 2019 •
edited
Loading

Add retry-routine to 'docker push' in clipper_docker.cfg.py
8113f4e 
This patch is needed to retry if 'docker push' fails. I found this error case through ucbrise#602 (comment).
@withsmilo withsmilo self-assigned this Mar 25, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1825/
Test FAILed.

@withsmilo withsmilo requested a review from simon-mo March 25, 2019 14:34
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1827/
Test FAILed.

@withsmilo
Copy link
Collaborator Author

jenkins test this please

@withsmilo withsmilo changed the title Add retry-routine to 'docker push' in clipper_docker.cfg.py [CI] Add retry-routine to 'docker push' in clipper_docker.cfg.py Mar 25, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1829/
Test FAILed.

@withsmilo withsmilo mentioned this pull request Mar 25, 2019
Closed
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1836/
Test FAILed.

@withsmilo
Copy link
Collaborator Author

jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1837/
Test FAILed.

@withsmilo withsmilo requested a review from RehanSD March 28, 2019 00:30
@RehanSD
Copy link
Collaborator

RehanSD commented Mar 28, 2019

Jenkins test this please.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1843/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1844/
Test PASSed.

@simon-mo simon-mo merged commit f97d769 into ucbrise:develop Mar 28, 2019
@withsmilo withsmilo deleted the add_retry_routine branch March 28, 2019 04:14
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 27, 2019
@rkooo567
[CI] Add retry-routine to 'docker push' in clipper_docker.cfg.py (ucb…
837953c 
…rise#655)

* Add retry-routine to 'docker push' in clipper_docker.cfg.py

This patch is needed to retry if 'docker push' fails. I found this error case through ucbrise#602 (comment).

* Move wait_and_pull_cmd() and wait_and_push_cmd() to proper location
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 28, 2019
@rkooo567
[CI] Add retry-routine to 'docker push' in clipper_docker.cfg.py (ucb…
478166f 
…rise#655)

* Add retry-routine to 'docker push' in clipper_docker.cfg.py

This patch is needed to retry if 'docker push' fails. I found this error case through ucbrise#602 (comment).

* Move wait_and_pull_cmd() and wait_and_push_cmd() to proper location
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 28, 2019
@rkooo567
[CI] Add retry-routine to 'docker push' in clipper_docker.cfg.py (ucb…
7781be2 
…rise#655)

* Add retry-routine to 'docker push' in clipper_docker.cfg.py

This patch is needed to retry if 'docker push' fails. I found this error case through ucbrise#602 (comment).

* Move wait_and_pull_cmd() and wait_and_push_cmd() to proper location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

@RehanSD RehanSD Awaiting requested review from RehanSD

Assignees

@withsmilo withsmilo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@withsmilo @AmplabJenkins @RehanSD @simon-mo