Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove metric log from query frontend #680

Merged
merged 1 commit into from
May 3, 2019
Merged

Remove metric log from query frontend #680

merged 1 commit into from
May 3, 2019

Conversation

simon-mo
Copy link
Contributor

No description provided.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1922/
Test PASSed.

@withsmilo
Copy link
Collaborator

@simon-mo , may I review this PR?

@simon-mo
Copy link
Contributor Author

simon-mo commented May 3, 2019

Yes please. You can merge it if it looks good to you.

@withsmilo withsmilo self-requested a review May 3, 2019 08:05
withsmilo
withsmilo approved these changes May 3, 2019
View reviewed changes
Copy link
Collaborator

@withsmilo withsmilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@withsmilo
Copy link
Collaborator

@simon-mo , please merge this PR because I don't have the merge permission. To be honest, our team has already applied this. :)

@withsmilo withsmilo merged commit 684070d into ucbrise:develop May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@withsmilo withsmilo withsmilo approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simon-mo @AmplabJenkins @withsmilo @rkooo567