-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print necessary stackstace information when crashed #700
Conversation
Test FAILed. |
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1975/ shows this error,
|
Jenkins test this please |
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general! I still have a couple questions.
- How is it different from just using
docker logs
on a broken container? Is it for our CI environment? 2. I found this notes frombacktrace_symbols_fd
backtrace() and backtrace_symbols_fd() don't call malloc()
explicitly, but they are part of libgcc, which gets loaded
dynamically when first used. Dynamic loading usually triggers a
call to malloc(3). If you need certain calls to these two
functions to not allocate memory (in signal handlers, for
example), you need to make sure libgcc is loaded beforehand.
Are we loading libgcc
beforehand? Is it already included in our compilation process?
EDIT -> Actually 2 might not matter because we print logs when containers are broken? Is docker container freeing all of its memory when it is broken?
@rkooo567
|
Test FAILed. |
Jenkins test this please |
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
No description provided.