Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TCP keep alive for redox #717

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Enable TCP keep alive for redox #717

merged 2 commits into from
Jun 4, 2019

Conversation

taohammer
Copy link
Contributor

Issue

Note

  • helps keep connections between mgmt_frontend, query_frontend and redis for a long idle time on k8s

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@withsmilo
Copy link
Collaborator

Jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2057/
Test FAILed.

Enable TCP keep alive for redox
7bab622 
 * helps keep connections between clipper and redis for a long idle time on k8s
@taohammer
Copy link
Contributor Author

Jenkins test this please

1 similar comment
@withsmilo
Copy link
Collaborator

Jenkins test this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2058/
Test PASSed.

@withsmilo withsmilo requested review from simon-mo and rkooo567 June 3, 2019 09:46
rkooo567
rkooo567 approved these changes Jun 3, 2019
View reviewed changes
Copy link
Collaborator

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simon-mo
Copy link
Contributor

simon-mo commented Jun 4, 2019

Jenkins ok to test

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2061/
Test PASSed.

@simon-mo simon-mo merged commit 19facc1 into ucbrise:develop Jun 4, 2019
@rkooo567 rkooo567 mentioned this pull request Jun 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@simon-mo simon-mo Awaiting requested review from simon-mo

Assignees

@taohammer taohammer

Labels
status: accepted type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taohammer @AmplabJenkins @withsmilo @simon-mo @rkooo567