Quick misc fixes #1501
Merged
Quick misc fixes #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clpetersonucf
approved these changes
Oct 3, 2023
| setCreatorState({...creatorState, invalid: false}) | ||
| setInstance({ ...instance, qset: data }) | ||
| } | ||
| if ( (data != null ? data.title : undefined) === 'Permission Denied' || (data && data.title === 'error')) { |
There was a problem hiding this comment.
This check won't catch data == null, but the API should never send a null object for this request. If an instance qset isn't found it sends a dummy one instead, so this should be sufficient.
| @@ -215,7 +215,7 @@ const MyWidgetsPage = () => { | |||
| widgetName: inst.widget.name, | |||
| dir: inst.widget.dir, | |||
| successFunc: (data) => { | |||
| if (!data || (data.type == 'error')) | |||
| if (data && (data.type == 'error')) | |||
There was a problem hiding this comment.
The lack of a null check here is probably fine since this is coming from the useDeleteWidget mutation which handles errors.
…ile pic corners because it looks good
clpetersonucf
changed the base branch from
issue/support-dashboard-in-react
to
dev/10.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
databefore accessing properties ondata(Ifdatais null, that is usually a sign something went wrong on the server; this is just a front-end band-aid)